Rotation Feature: #7541
Open
Rotation Feature: #7541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filename will be prepended with the system timestamp in YYYYMMDD_hhmmss-<Tag> format - A new attribute "Rotation" of type Integer added - Value of Rotation specifies the frequency of log rotation in minutes - Value of rotation can be in the range of [1 - 1440 (1 day)]
balaji17091982
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
| if (str == NULL) { | ||
| return 0; | ||
| } | ||
| return(atoi(str)); |
There was a problem hiding this comment.
I think this probably needs a lot more defensive code around it to handle all the possible failure outcomes and "undefined behaviour" of atoi: https://cplusplus.com/reference/cstdlib/atoi/
It should also test invalid strings, etc. to confirm.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.